Skip unnecessary json.Unmarshal in converter #933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optimization when loading object/array-like types dependent on
jsonConverter
. We can skip this marshal+unmarshal combo and simply marshal it and cast the result to the requiredjson.RawMessage
.Looks like this was added to convert
[]byte
tojson.RawMessage
, but both types are already[]byte
so we can simply cast it.Changes:
jsonConverter