Update trace queries to better handle time fields #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use the following command to run this PR with Docker at http://localhost:3000: |
SpencerTorres
suggested changes
Jul 3, 2024
SpencerTorres
approved these changes
Jul 3, 2024
adamyeats
approved these changes
Jul 9, 2024
|
Thank you ⸜(｡˃ ᵕ ˂ )⸝♡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traces are currently displayed with the wrong timing due to discrepancies between how the trace visualisation handles times and how the Javascript
Datetype functions (it doesn't correctly handle sub-millisecond precision).Fixes #888 by converting the time field to nanoseconds and then adjusting it to milliseconds.