feature: add $__dateTimeFilter()
macro
#872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds a
$__dateTimeFilter(dateColumn, timeColumn)
that expands into:Why?
A common pattern in ClickHouse is having an
ORDER BY
that looks like this:PARTITION BY toYYYYMM(TimestampDate) ORDER BY (TimestampDate, TimestampTime)
Where
TimestampDate
is aDate
andTimestampTime
is aDateTime
.When querying this, it is common to do
$__dateFilter(TimestampDate) AND $__timeFilter(TimestampTime)
. This macro makes it shorter to type, by being able to do$__dateTimeFilter(TimestampDate, TimestampTime)
.With this macro it is faster and more efficient to query tables that have this pattern of partitioning, since it references both time columns.