-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Column alias tables for simplified querying #862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆 love it, nicely done!
The array change you suggested worked locally, I didn't get any errors when unit testing or in-editor, but the build seemed to be failing. I tried updating to a typescript version that supports that extension and it lead to a complete collapse of the plugin's package ecosystem. I think I even saw leftpad mentioned in the logs. Anyway, let me know if you want me to try again. I want to use that new feature, but there's a lot of dependencies affected by updating TS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Purpose
Some schemas have complicated maps such as OTel
LogAttributes
. This feature allows configuring a table like this:This table can then be configured in the plugin:
And then be used for the target table's column suggestions:
With the column selection simplified, the correct SQL will be generated using the underlying
select
syntax:Notes:
DESC TABLE
for column suggestions.ALIAS
column type, but this feature allows for easier maintenance without having to run bulk updates on your primary table (some schemas may have thousands of alias entries).Changes
label
, which defaults to the field name if an alias doesn't override it.