Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump grafana-plugin-sdk-go to v0.220.0 #790

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Bump grafana-plugin-sdk-go to v0.220.0 #790

merged 1 commit into from
Apr 5, 2024

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented Apr 5, 2024

This is necessary as v0.217.0 includes a PDC bug.

@wbrowne wbrowne requested a review from a team as a code owner April 5, 2024 10:23
@wbrowne
Copy link
Member Author

wbrowne commented Apr 5, 2024 •
edited
Loading

@grafana/partner-datasources it looks like we have a release (4.0.4) with the v0.217.0 SDK version - can you confirm if I got that wrong or not? Since this plugin supports PDC so we should remove this release from the catalog in case customers end up running into this issue (we can make a release here, move customers off the latest version onto the new version and remove the problematic version from the catalog)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:eca9970d8c81654e83e8765830ba321dcd76ebf8pre

@aangelisc
Copy link
Contributor

Hey @wbrowne, that's accurate. I'm going to approve this and then we can look at releasing

@wbrowne
Copy link
Member Author

wbrowne commented Apr 5, 2024

Hey @wbrowne, that's accurate. I'm going to approve this and then we can look at releasing

Looks like I can't merge, so work away. Thank you! ❤️

@aangelisc aangelisc merged commit 6c36d91 into main Apr 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbrowne @aangelisc