Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix *_trace_id_ts table #768

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

SpencerTorres
Copy link
Collaborator

Fixes #762 and #761

Previously, the table was hardcoded as otel_traces_trace_id_ts, but now it takes the current table name and appends the suffix, similar to how it works in the otel collector. For example, if your table is my_traces, the trace timestamp table would be my_traces_trace_id_ts.

@SpencerTorres SpencerTorres requested a review from a team as a code owner March 20, 2024 18:40
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice 🏆

@asimpson asimpson enabled auto-merge (squash) March 21, 2024 19:41
@asimpson asimpson merged commit 0c56685 into grafana:main Mar 21, 2024
16 checks passed
@SpencerTorres SpencerTorres deleted the fix_trace_ts_table branch June 17, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom trace table prefix does not work on grafana tracing
2 participants