Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Grafana version from context #610

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Get Grafana version from context #610

merged 2 commits into from
Dec 6, 2023

Conversation

adamyeats
Copy link
Contributor

@adamyeats adamyeats commented Nov 23, 2023 •
edited
Loading

This PR allows the Grafana version number to be read from context, instead of reading from the GF_VERSION environment variable.

@adamyeats adamyeats added datasource/ClickHouse go Pull requests that update Go code labels Nov 23, 2023
@adamyeats adamyeats self-assigned this Nov 23, 2023
@adamyeats adamyeats force-pushed the retrieve-grafana-version-from-context branch from e3e5d65 to 29474ec Compare December 4, 2023 13:50
@adamyeats adamyeats marked this pull request as ready for review December 4, 2023 13:50
@adamyeats adamyeats requested a review from a team as a code owner December 4, 2023 13:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:99db9e09dc1e5bf594bea7703ab8f08ce115b3d5pre

@asimpson asimpson enabled auto-merge (squash) December 6, 2023 15:38
@asimpson asimpson merged commit 128828e into main Dec 6, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees

@adamyeats adamyeats

Labels
datasource/ClickHouse go Pull requests that update Go code
Projects
Partner Datasources
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamyeats @asimpson