Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queries with SETTINGS clauses no longer get AST errors #530

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Queries with SETTINGS clauses no longer get AST errors #530

merged 8 commits into from
Oct 3, 2023

Conversation

bossinc
Copy link
Collaborator

@bossinc bossinc commented Sep 28, 2023

Settings are removed from the SQL before trying to make an ast. We do not need settings with the AST.

Solves #520

@bossinc bossinc requested a review from a team as a code owner September 28, 2023 22:38
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:e3c6bb8c19f958cb3a92bc40f18546d2ec8fea64pre

aangelisc
aangelisc previously approved these changes Sep 29, 2023
View reviewed changes
asimpson
asimpson approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this 🏆

@araujobsd
Copy link

Nice, thanks a lot :)

@bossinc bossinc merged commit e565f43 into main Oct 3, 2023
13 checks passed
@bossinc bossinc deleted the settings-ast-bug branch October 3, 2023 17:04
@asimpson asimpson mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@aangelisc aangelisc aangelisc left review comments

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bossinc @araujobsd @asimpson @aangelisc