Fix AST parsing when switching back to query builder #1002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AST module we use for parsing SQL is still not fully compatible with ClickHouse SQL, but there are things we can fix.
The button to switch from "SQL" to "Query Builder" has not been working as expected the past few releases, this aims to fix and enhance its capabilities.
old button (dramatized):
new behavior (query is actually somewhat parsed correctly, columns are put into their associated boxes):
I have added some logic to help properly map log/trace column names to their correct boxes based on the SQL column names/aliases.
Changes:
Other notes:
ResourceAttributes['host']
)"Timestamp"
), otherwise it will be forced to lowercase. This behavior comes from the postgres AST module.ORDER BY
should also used a quoted identifier, else it will try to use the lowercased identifier and likely throw an error when executing the query.EXPLAIN AST
, but this does not include the required information to rebuild the query. Perhaps a hybrid approach would work?