Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to see trace details when using distributed tables. #761

Closed
mlsalcedo opened this issue Mar 14, 2024 · 5 comments
Closed

Failing to see trace details when using distributed tables. #761

mlsalcedo opened this issue Mar 14, 2024 · 5 comments
Assignees
Labels

Comments

@mlsalcedo
Copy link

mlsalcedo commented Mar 14, 2024

What happened: When updating the datasource configuration to use distributed tables, there's not a way to update traceTimestampTable configuration, which is used by trace details view.

What you expected to happen: A way to override traceTimestampTable configuration in the trace section.

How to reproduce it (as minimally and precisely as possible):

  1. Create distributed tables for all otel tables.
  2. Update Otel Collector and Datasource configuration to use distributed tables.
  3. Go to the Explorer -> Trace tab, run the query and tried to see the details from a given trace id.

Environment:

  • Grafana version: docker.io/grafana/grafana:10.3.3
  • Plugin version: 4.0.3
  • OS Grafana is installed on: Kuberntes 1.24
@SpencerTorres
Copy link
Collaborator

Thanks for submitting this issue!

We can make this configurable, but it is tied to the otel version. Perhaps we can allow adding your own otel version in the YAML config, or at least some overrides.

@SpencerTorres SpencerTorres added enhancement New feature or request and removed type/bug Something isn't working labels Mar 14, 2024
@SpencerTorres
Copy link
Collaborator

A temporary workaround would be to disable "Use OTel" after opening the trace editor (once the otel columns are applied), or in the config (if you do it in the config you'll have to manually write all the column names)

Disabling "Use OTel" will disable the performance enhancement of using the timestamp table. Slower queries, but should work for now

@SpencerTorres
Copy link
Collaborator

SpencerTorres commented Mar 15, 2024

This is similar to #762, and it might offer a simpler solution. We can simply use the currently selected trace table, and append the exporter's _trace_id_ts suffix to it.

For example, otel_traces becomes otel_traces_trace_id_ts. Or if you have a custom table custom_traces becomes custom_traces_trace_id_ts

Depending on the flexibility you need, this could be a valid solution assuming your custom table names are consistent with what the exporter uses

@SpencerTorres
Copy link
Collaborator

A fix has been merged and will be available in the next release

@github-project-automation github-project-automation bot moved this from Backlog to Done in Partner Datasources Mar 25, 2024
@mlsalcedo
Copy link
Author

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants