Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remotecfg: add some basic metrics #894

Merged
merged 7 commits into from
May 21, 2024
Merged

remotecfg: add some basic metrics #894

merged 7 commits into from
May 21, 2024

Conversation

captncraig
Copy link
Contributor

@captncraig captncraig commented May 21, 2024 •
edited
Loading

New metrics:

  • remotecfg_hash
  • remotecfg_last_load_successful
  • remotecfg_load_failures_total
  • remotecfg_last_load_success_timestamp_seconds
  • remotecfg_load_attempts_total
  • remotecfg_request_duration_seconds

Component loading info should already be exposed via controller metrics.

This does not give any insight into the fallback local files, and is focused mainly on the remote fetch.

@mattdurham
Copy link
Collaborator

Are we always injecting these metrics even if someone is not using remote config?

@captncraig
Copy link
Contributor Author

Are we always injecting these metrics even if someone is not using remote config?

Good point. Not everything is very good about deferring registration, but no reason this couldn't.

mattdurham
mattdurham approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but would love if we could only have the metrics registered if using remote configuration.

@captncraig captncraig enabled auto-merge (squash) May 21, 2024 18:27
@captncraig captncraig merged commit 642ab21 into main May 21, 2024
18 checks passed
@captncraig captncraig deleted the cmp_remotecfg_metrics branch May 21, 2024 18:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattdurham mattdurham mattdurham approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captncraig @mattdurham