Update paths, references to River, and config/binary paths and names #84
Conversation
clayton-cornell
added
the
type/docs
There was a problem hiding this comment.
This file isn't templated/rendered to the docs site so {{< param "PRODUCT_NAME" >}} should be replaced with literal "Alloy" instances here
There was a problem hiding this comment.
Fixed in a new PR
| @@ -7,7 +7,7 @@ weight: 300 | |||
|
|
|||
| # Collect OpenTelemetry data | |||
|
|
|||
| {{< param "PRODUCT_NAME" >}} can be configured to collect [OpenTelemetry][]-compatible data and forward it to any OpenTelemetry-compatible endpoint. | |||
| Youc an configure {{< param "PRODUCT_NAME" >}} to collect [OpenTelemetry][]-compatible data and forward it to any OpenTelemetry-compatible endpoint. | |||
There was a problem hiding this comment.
Fixed in a new PR
| @@ -56,7 +55,7 @@ binary, perform the following steps: | |||
|
|
|||
| 1. Type `services.msc` and click **OK**. | |||
|
|
|||
| 1. Right click on the service called **{{< param "PRODUCT_NAME" >}}**. | |||
| 1. Right click on the service called **{{< param "FULL_PRODUCT_NAME" >}}**. | |||
There was a problem hiding this comment.
Based on the current spreadsheet, this might not be correct anymore (Alloy, not Grafana Alloy). Maybe in this particular case we should spell it out explicitly rather than using the param so it's easier to review when looking at the raw markdown?
There was a problem hiding this comment.
I missed that one in this edit. Fixed in a new PR
| @@ -31,7 +31,7 @@ If you are running a custom installation of {{< param "PRODUCT_NAME" >}}, refer | |||
|
|
|||
| ### Home page | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
will these URLs be changed to Alloy later?
There was a problem hiding this comment.
All images will need to be updated for Alloy - most are Agent-specific screencaps.
| @@ -5,7 +5,7 @@ title: Monitor controller | |||
| weight: 100 | |||
| --- | |||
|
|
|||
| # How to monitor controller | |||
| # Monitor controller | |||
There was a problem hiding this comment.
Feels weird for an article to be missing here. "Monitor the controller?" (or "Monitor the component controller?")
There was a problem hiding this comment.
Yeah I had that one flagged to come back to in a content tidy. Fixed the H1 level in a new PR. Now it reads Monitor the Grafana Agent component controller (H1 should spell out the full product name, Grafana Alloy)
rfratto
added
the
backport-to-agent:no
PR Description
Update paths, references to River, and config/binary paths and names
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist