Add info about order of arguments when customising the Windows config #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
type/docs
|
Hm, the argument isn't positional though, so I think there's a different underlying issue here. What were the custom arguments passed that caused the issue? |
|
@clayton-cornell I'm not able to reproduce an issue where the ordering matters here. Swapping the order worked for me:
I suspect the underlying issue here was not ensuring each argument was placed on its own line in the Edit Multi-String box. Maybe we can document that as a requirement instead? |
rfratto
added
backport-to-agent
rfratto
approved these changes
May 14, 2024
clayton-cornell
added a commit
that referenced
this pull request
May 14, 2024
…#837) (#846) * Add info to step 4 about order of arguments * Update advice about arguments (cherry picked from commit 3ad652a) Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
added a commit
that referenced
this pull request
May 14, 2024
…#837) (#847) * Add info to step 4 about order of arguments * Update advice about arguments (cherry picked from commit 3ad652a) Co-authored-by: Clayton Cornell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add info about order of arguments when customising the Windows config.
If the storage.path argument is not last in the set of custom arguments, you will get the following error:
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist