fix: Ensure HTTP server startup errors are logged (#694) #700
Conversation
This commit modifies the goroutine that starts the HTTP server to explicitly log any errors encountered during startup, except for `http.ErrServerClosed`, which is expected during graceful shutdown. This change ensures that issues related to the server's startup, such as the address already being in use, are logged, making it easier to diagnose and fix. Closes grafana#694
|
Mohamad Rashad seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
As this is my first contribution, I welcome all your feedback and advice. |
| @@ -44,7 +44,11 @@ func main() { | |||
| }() | |||
| log.Printf("HTTP server on %s", listenAddress) | |||
|
|
|||
| go func() { log.Fatal(server.ListenAndServe()) }() | |||
| go func() { | |||
There was a problem hiding this comment.
I think you made changes in the wrong place. This main.go's purpose is to run integration tests.
Robert already pointed at possibility of logging out the error before return it here. Could use something like level.Error(s.log).Log("failed to start HTTP service", "msg", err.Error()
alloy/internal/service/http/http.go
Line 154 in c6f4f30
|
hi @mrashad10, are you still working on this PR? If anything's troubling you, feel free to raise it here! |
|
Hi @hainenber Sorry but I was busy last 2 weeks, I'm not sure that I will have time to work on it this week too. |
|
This PR has not had any activity in the past 30 days, so the |
Bugfixes
PR Description
This commit modifies the go routine that starts the HTTP server to explicitly log any errors encountered during startup, except for
http.ErrServerClosed, which is expected during graceful shutdown. This change ensures that issues related to the server's startup, such as the address already being in use, are logged, making it easier to diagnose and fix.Which issue(s) this PR fixes
Fixes #694
Notes to the Reviewer
PR Checklist