Add additional buckets to fanout histogram #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The prometheus_fanout_latency is used to measure latencies for data
moving between components.
- The default buckets are limited to 10s, which limits the ability
detect very high latencies.
- Adds to additional buckets (30s, 60s) for additional resolution.
- Note: I initially planned to replace some of the existing buckets
instead of adding new ones, but I believe most components will fall
into the smaller buckets and reducing the resolution there would
lead to distortions in the quantile calculations (and potentially
create the ilusion of performance degradation). Note however that
the 2 new buckets will result in increased cardinality of 2 metrics
per collector instance.
thampiotr
approved these changes
Apr 30, 2024
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
- The prometheus_fanout_latency is used to measure latencies for data
moving between components.
- The default buckets are limited to 10s, which limits the ability
detect very high latencies.
- Adds to additional buckets (30s, 60s) for additional resolution.
- Note: I initially planned to replace some of the existing buckets
instead of adding new ones, but I believe most components will fall
into the smaller buckets and reducing the resolution there would
lead to distortions in the quantile calculations (and potentially
create the ilusion of performance degradation). Note however that
the 2 new buckets will result in increased cardinality of 2 metrics
per collector instance.
polyrain
pushed a commit
to polyrain/alloy
that referenced
this pull request
May 1, 2024
- The prometheus_fanout_latency is used to measure latencies for data
moving between components.
- The default buckets are limited to 10s, which limits the ability
detect very high latencies.
- Adds to additional buckets (30s, 60s) for additional resolution.
- Note: I initially planned to replace some of the existing buckets
instead of adding new ones, but I believe most components will fall
into the smaller buckets and reducing the resolution there would
lead to distortions in the quantile calculations (and potentially
create the ilusion of performance degradation). Note however that
the 2 new buckets will result in increased cardinality of 2 metrics
per collector instance.
rfratto
added
the
backport-to-agent:no
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Notes to the Reviewer