Removed extra tab in yaml example #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two extra spaces in the example for values.yaml when using existing configmap. This was resulting in the following error:
```
Error: UPGRADE FAILED: template: alloy/templates/controllers/daemonset.yaml:20:8: executing "alloy/templates/controllers/daemonset.yaml" at <include "alloy.pod-template" .>: error calling include: template: alloy/templates/controllers/_pod.yaml:2:42: executing "alloy.pod-template" at <.Values.alloy>: wrong type for value; expected map[string]interface {}; got interface {}
```
|
|
tpaschalis
approved these changes
Apr 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
(cherry picked from commit 6947bad)
tpaschalis
pushed a commit
that referenced
this pull request
Apr 25, 2024
(cherry picked from commit 6947bad) Co-authored-by: dd-georgiev <[email protected]>
clayton-cornell
added
the
type/docs
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
rfratto
added
the
backport-to-agent:no
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two extra spaces in the example for values.yaml when using existing configmap. This was resulting in the following error:
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist