fix(faro/receiver): extra_log_labels with empty value now map to existing value in log line #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting value in log line Signed-off-by: hainenber <[email protected]>
tpaschalis
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
LGTM, makes sense! (and apologies for the belated review).
cc @rlankfo @mar4uk for awareness, this is a port of grafana/agent#6641
hainenber
added a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
…ting value in log line (grafana#632) Signed-off-by: hainenber <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #296
Fixes #619
Notes to the Reviewer
PR Checklist