-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push build images for Alloy on tags of build-image/v*
#625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reenables the build image pipeline, as grafana/alloy-build-image is now available for pushing.
Align tag names of build-images with Alloy, so that the v prefix is included in the tag name.
tpaschalis
reviewed
Apr 22, 2024
tpaschalis
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rfratto
added a commit
to rfratto/alloy
that referenced
this pull request
Apr 22, 2024
The final commit of grafana#625 forgot to re-run `make drone`.
Merged
rfratto
added a commit
that referenced
this pull request
Apr 22, 2024
rfratto
added
the
backport-to-agent:no
PR should NOT be backported to the agent repo.
label
Apr 23, 2024
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
* ci: reenable build image pipeline This commit reenables the build image pipeline, as grafana/alloy-build-image is now available for pushing. * ci: push grafana/alloy-build-image on tags of build-image/vX.Y.Z. * ci: align tag names of build-image with Alloy Align tag names of build-images with Alloy, so that the v prefix is included in the tag name. * tools/build-image: document boringcrypto image
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
The final commit of grafana#625 forgot to re-run `make drone`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the ability to push build images for Alloy with images called
grafana/alloy-build-image
.Unlike
grafana/agent-build-image
, thev
prefix is added to tag names to align with all other images pushed within the Alloy project.