mimir.rules.kubernetes: Don't retry unrecoverable errors #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
changed the title
56quarters
force-pushed
the
56quarters/event-retry
branch
2 times, most recently
from
e19514a to
1d5b73a
Compare
56quarters
commented
Apr 19, 2024
56quarters
force-pushed
the
56quarters/event-retry
branch
from
58fe912 to
233bc0f
Compare
rfratto
reviewed
Apr 23, 2024
ptodev
approved these changes
Apr 23, 2024
Change event processing to immediately stop applying changes to Mimir in response to events that cause HTTP 4XX errors. These errors indicate the request is malformed and will never succeed so there's no point retrying it. Fixes #610 Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
force-pushed
the
56quarters/event-retry
branch
from
a57241f to
f65a49d
Compare
Signed-off-by: Nick Pillitteri <[email protected]>
rfratto
approved these changes
Apr 23, 2024
4 tasks
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
Change event processing to immediately stop applying changes to Mimir in response to events that cause HTTP 4XX errors. These errors indicate the request is malformed and will never succeed so there's no point retrying it. Fixes grafana#610 Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Change event processing to immediately stop applying changes to Mimir in response to events that cause HTTP 4XX errors. These errors indicate the request is malformed and will never succeed so there's no point retrying it.
Which issue(s) this PR fixes
Fixes #610
Notes to the Reviewer
This PR probably conflicts with #158 and will need to be rebased .DonePR Checklist