Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Corrects Beyla excutable_name to executable_name. #586

Merged
merged 1 commit into from
Apr 16, 2024
Merged

docs: Corrects Beyla excutable_name to executable_name. #586

merged 1 commit into from
Apr 16, 2024

Conversation

hedss
Copy link
Contributor

@hedss hedss commented Apr 16, 2024

PR Description

Ensures that users aren't confused by an incorrect naming scheme, where the docs specify excutable_name where they should specify executable_name in the Beyla documentation, to match the code.

Which issue(s) this PR fixes

N/A

Notes to the Reviewer

N/A

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@hedss
docs: Corrects Beyla excutable_name to executable_name.
eda1a16 
Ensures that users aren't confused by an incorrect naming scheme.

Signed-off-by: Heds Simons <[email protected]>
@hedss hedss requested a review from clayton-cornell as a code owner April 16, 2024 01:03
@hedss hedss requested a review from marctc April 16, 2024 01:03
@hedss hedss added documentation Improvements or additions to documentation type/docs Docs Squad label across all Grafana Labs repos labels Apr 16, 2024
tpaschalis
tpaschalis approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tpaschalis tpaschalis merged commit ce26365 into grafana:main Apr 16, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
@hedss @grafanabot
docs: Corrects Beyla excutable_name to executable_name. (#586)
3a058d1 
Ensures that users aren't confused by an incorrect naming scheme.

Signed-off-by: Heds Simons <[email protected]>
(cherry picked from commit ce26365)
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Merged
tpaschalis pushed a commit that referenced this pull request Apr 16, 2024
@github-actions @hedss
docs: Corrects Beyla excutable_name to executable_name. (#586) (#587
6822b42 
)

Ensures that users aren't confused by an incorrect naming scheme.

Signed-off-by: Heds Simons <[email protected]>
(cherry picked from commit ce26365)

Co-authored-by: Heds Simons <[email protected]>
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tpaschalis tpaschalis tpaschalis approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

@marctc marctc Awaiting requested review from marctc

Assignees
No one assigned
Labels
backport release/v1.0 backport-to-agent:no PR should NOT be backported to the agent repo. documentation Improvements or additions to documentation frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hedss @tpaschalis @rfratto