Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web/ui): fix issue where text labels displayed outside of component's node boundary #582

Merged

Conversation

hainenber
Copy link
Contributor

PR Description

Graph rendering on Chrome-based browsers are intact (I'm using Edge for example)

image

Fixed the issue in Firefox
image

As a bonus, Safari is fine and dandy
image

Which issue(s) this PR fixes

Fixes #183

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have absolutely zero experience with frontend design, but since this a) looks alright and b) doesn't read that complicated/intrusive, I'd think it's OK to check this in.

Waiting to see if anyone from the team has any feedback before we merge.

@tpaschalis tpaschalis merged commit 6585e5a into grafana:main Apr 19, 2024
9 of 10 checks passed
@hainenber hainenber deleted the fix-out-of-bound-graph-rendering-in-firefox branch April 19, 2024 09:02
@rfratto rfratto added the backport-to-agent PR should be backported to the agent repo. label Apr 23, 2024
hainenber added a commit to hainenber/alloy that referenced this pull request May 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-to-agent PR should be backported to the agent repo. frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Graph renders incorrectly on Firefox
3 participants