Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): rectify actual Agent-to-Alloyconverted result from static config #570

Merged

Conversation

hainenber
Copy link
Contributor

I ran the convert command from from-static.md and the actual results is a bit different compared to what described in the doc. This PR is to rectify such defect

image

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

N/A

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@tpaschalis tpaschalis enabled auto-merge (squash) April 15, 2024 12:21
@tpaschalis tpaschalis merged commit 9fa6d2f into grafana:main Apr 15, 2024
10 checks passed
@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release/v1.0 labels Apr 16, 2024
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
…c config (#570)

Signed-off-by: hainenber <[email protected]>
(cherry picked from commit 9fa6d2f)
clayton-cornell pushed a commit that referenced this pull request Apr 16, 2024
…c config (#570) (#590)

Signed-off-by: hainenber <[email protected]>
(cherry picked from commit 9fa6d2f)

Co-authored-by: Đỗ Trọng Hải <[email protected]>
@rfratto rfratto added the backport-to-agent PR should be backported to the agent repo. label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release/v1.0 backport-to-agent PR should be backported to the agent repo. frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants