Fix topics in loki.source.kafka #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted. |
thampiotr
approved these changes
Jan 8, 2025
thampiotr
approved these changes
Jan 8, 2025
clayton-cornell
added
the
type/docs
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The code claims that it will use regex if the topic name starts with "^" but it actually always uses regex. As a result, if you have the topic "foo" and "foobar", you will match both by setting "foo" only.
The fix prevents this from happening by using exact match by default and documenting the possible use of regex.
This is technically a breaking change for users relying on the undocumented regex behavior.
To avoid the breaking change, we could document that an exact match can be achieved by having the name start with "^" and end with "$" but I would prefer fixing this to match the intended way. Because the use of regex was undocumented, it does not breach our backward compatibility statement.