pyroscope.java: bump async-profiler binaries #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
changed the title
korniltsev
approved these changes
Jan 6, 2025
|
lgtm |
|
Should we document that it should not be profiling production environments? |
|
@mattdurham you are probably referring to my comment in the description, specifically on Darwin support. We only mention Linux in our component reference docs and I haven't seen any requests for Darwin support so far (java workloads are typically run on Linux). I'd avoid mentioning Darwin support unless we have incoming questions on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Update the async-profiler binaries used in
pyroscope.javato a newer nightly build. There hasn't been an official release of async-profiler since Jan 20, 2024, however numerous bug-fixes and improvements have been made in the last year, including moving to universal binaries.Also adds darwin support for
pyroscope.java, primarily meant for aiding local development and not intended for profiling in production environments.PR Checklist
@grafana/pyroscope-team