fix(loki.secretfilter): Fix partial masking for short secrets and support multiple allowlists per rule #2320
+238
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted. |
romain-gaillard
requested review from
clayton-cornell and
a team
as code owners
mattdurham
reviewed
Jan 6, 2025
mattdurham
reviewed
Jan 6, 2025
mattdurham
reviewed
Jan 6, 2025
| Regexes []string | ||
| } | ||
| Rules []struct { | ||
| ID string | ||
| Description string | ||
| Description string // Not used |
There was a problem hiding this comment.
Are these unused variables still here so the format processes? What is the harm in removing them?
There was a problem hiding this comment.
Yes, indeed they could be removed. I initially added them to keep track of features we don't currently support but might in the future.
There was a problem hiding this comment.
In that case I would rather remote/comment out the whole line so they cant mistakenly be used.
There was a problem hiding this comment.
👍 I removed it
clayton-cornell
added
the
type/docs
Co-authored-by: Clayton Cornell <[email protected]>
mostafa
approved these changes
Jan 10, 2025
|
@clayton-cornell @mattdurham |
|
Will merge once clayton approves. |
clayton-cornell
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
partial_maskvalue.[[rules.allowlists]]format added in Gitleaks v8.21.0Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist