improve regexp performance in loki.process: call fmt only if debug …
#2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
reviewed
Jan 7, 2025
…is enabled. surrounding rest of the debug messages with debug check.
wildum
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
improve regexp performance in loki.process: call fmt only if debug is enabled
Notes to the Reviewer
Was doing promtail vs alloy perf tests, and found that alloy consumes at least 40% more CPU than promtail.
here is the link for cpu.pprof
alloy cpu pprof
promtail cpu pprof
PR Checklist
[ X] CHANGELOG.md updated