Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve regexp performance in loki.process: call fmt only if debug … #2271

Closed
wants to merge 1 commit into from

Conversation

r0ka
Copy link
Contributor

@r0ka r0ka commented Dec 12, 2024

PR Description

Which issue(s) this PR fixes

improve regexp performance in loki.process: call fmt only if debug is enabled

Notes to the Reviewer

Was doing promtail vs alloy perf tests, and found that alloy consumes at least 40% more CPU than promtail.
here is the link for cpu.pprof
cpu pprof

PR Checklist

  • [ X] CHANGELOG.md updated

@r0ka r0ka requested a review from a team as a code owner December 12, 2024 14:06
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Roman Karpenko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@r0ka r0ka closed this Dec 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants