Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ignore_older option for local.file_match #2245

Merged
merged 7 commits into from
Dec 13, 2024
Merged

feat: Add ignore_older option for local.file_match #2245

merged 7 commits into from
Dec 13, 2024

Conversation

ravishankar15
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Fixes #2214

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated

@ravishankar15 ravishankar15 requested review from clayton-cornell and a team as code owners December 8, 2024 13:25
wildum
wildum reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a few nits comments, it looks really good, the one line logic is cool

internal/component/local/file_match/watch.go Show resolved Hide resolved
docs/sources/reference/components/local/local.file_match.md Outdated Show resolved Hide resolved
internal/component/local/file_match/file_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
internal/component/local/file_match/file.go Outdated Show resolved Hide resolved
wildum
wildum approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for another great contribution, you're helping us a lot! :)

@wildum wildum merged commit 61a9a09 into grafana:main Dec 13, 2024
15 of 16 checks passed
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Dec 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clayton-cornell clayton-cornell clayton-cornell left review comments

@ptodev ptodev ptodev left review comments

@dehaansa dehaansa dehaansa left review comments

@wildum wildum wildum approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local.file_match ignore older files
5 participants
@ravishankar15 @dehaansa @ptodev @wildum @clayton-cornell