Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update documentation for using filename in otelcol.auth.bearer component #2213

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: Update documentation for using filename in otelcol.auth.bearer component #2213

merged 2 commits into from
Dec 11, 2024

Conversation

ravishankar15
Copy link
Contributor

@ravishankar15 ravishankar15 commented Dec 3, 2024 •
edited
Loading

PR Description

Which issue(s) this PR fixes

#1988

Notes to the Reviewer

PR Checklist

  • Documentation added

@ravishankar15 ravishankar15 requested review from clayton-cornell and a team as code owners December 3, 2024 17:21
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Dec 3, 2024
@clayton-cornell clayton-cornell requested a review from a team December 4, 2024 00:57
@mattdurham
Copy link
Collaborator

We generally do not use file based secrets anymore. Can what you want be achieved with local.file?

@ravishankar15
Copy link
Contributor Author

Hi @mattdurham Can you check the thread from the issue i think this was discussed a bit there. #1988

@ravishankar15 ravishankar15 changed the title feat: Add filename support for otelcol.auth.bearer component fix: Update documentation for using filename in otelcol.auth.bearer component Dec 7, 2024
@clayton-cornell
Copy link
Contributor

@wildum @mattdurham I'm a bit confused here. Does this doc change actually cover what is needed? Do I understand this correctly that if the user is storing a token in a file somewhere, they can... retrieve the token somehow using local.file? Looking at this comment: #1988 (comment) I'm not sure the proposed doc change covers it all... but I might be missing a detail here too.

@wildum
Copy link
Contributor

wildum commented Dec 9, 2024 •
edited
Loading

@clayton-cornell that's correct, the upstream component has a "filename" attribute that can be used to retrieve a secret but we decided not to have it in Alloy and instead tell the users to use the local.file component to retrieve the secret from the file and send it to this component via the token attribute.

@wildum wildum merged commit 14c3bd2 into grafana:main Dec 11, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell clayton-cornell left review comments

@wildum wildum wildum approved these changes

Assignees
No one assigned
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravishankar15 @mattdurham @clayton-cornell @wildum