fix: support capitalized relabel actions to match with prometheus-operator behavior #2209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The prometheus operator
ServiceMonitors
,PodMonitors
andProbes
relabelings sections support capitalized actions like so: https://github.com/prometheus-operator/prometheus-operator/blob/ccfd2196833a350100658b9d645f0935e3b90a3d/example/prometheus-operator-crd/monitoring.coreos.com_podmonitors.yaml#L349The issue is prometheus itself only supports lowercase actions so the prometheus-operator maintainers added https://github.com/prometheus-operator/prometheus-operator/blob/ccfd2196833a350100658b9d645f0935e3b90a3d/pkg/prometheus/resource_selector.go#L294 to lowercase actions.
This PR aims to reproduce this as incorrect values like "Replace" actually causes alloy to panic like so:
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist