Retry running a CRD Manager if it fails #2202
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
thampiotr
reviewed
Dec 2, 2024
| level.Error(c.opts.Logger).Log("msg", "error running crd manager", "err", err) | ||
| errChan <- err | ||
| //TODO: What is a good default value for this? | ||
| retryInterval = 30 * time.Second |
There was a problem hiding this comment.
Let's use backoff to avoid thundering herd problems. You can use a similar approach to this: https://github.com/grafana/alloy/blob/main/internal/runtime/internal/controller/loader.go#L732
| for { | ||
| select { | ||
| case <-innerCtx.Done(): | ||
| //TODO: Log that the manager is exiting? |
There was a problem hiding this comment.
I'd say let's add a debug level just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Setting up a k8s informer may time out (see #2161). In that case, we'd only retry setting up an informer the next time Alloy's config changes. We should retry sooner than that, since the config may never change.
Notes to the Reviewer
A few reasons why the PR is in draft stage:
PR Checklist