feat: Add new stdlib functions #2199
Conversation
ravishankar15
requested review from
clayton-cornell and
a team
as code owners
|
|
syntax/internal/stdlib/stdlib.go
Outdated
| "from_yaml": yamlDecode, | ||
| "from_base64": base64Decode, | ||
| "to_base64": base64Encode, | ||
| "to_URLbase64": base64URLEncode, |
There was a problem hiding this comment.
Should there be an appropriate from_urlbase64?
There was a problem hiding this comment.
Have added the same makes sense since to have decode when we have the encode
| The `encoding.to_base64` function encodes a string to RFC4648-compliant base64 string | ||
| into the original string. |
There was a problem hiding this comment.
| The `encoding.to_base64` function encodes a string to RFC4648-compliant base64 string | |
| into the original string. | |
| The `encoding.to_base64` function encodes a string to an RFC4648-compliant Base64 string into the original string. |
The wording here seems awkward. I'm not sure how to phrase it so it's still technically correct. @mattdurham could we say something along the lines of The `encoding.to_base64` function encodes a string to an RFC4648-compliant Base64 string and writes it into the original string.? Or does it overwrite the original string? Or something else?
There was a problem hiding this comment.
I hope the new verbal change makes sense.
ravishankar15
force-pushed
the
new-stdlib-func
branch
from
04f4c95 to
0c033b1
Compare
|
Hi Team, I have addressed the review comments please take a look. |
clayton-cornell
added
the
type/docs
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
|
Addressed the commit suggestions |
There was a problem hiding this comment.
Approving for doc input. It will still need code review @mattdurham
|
LGTM thanks for the PR! |
PR Description
Adds two new stdlib functions to_base64 and to_URLbase64
Which issue(s) this PR fixes
#2048
Notes to the Reviewer
PR Checklist