Fixes to database_observability samples collector
#2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewnolf
changed the title
database_observability samples colllectordatabase_observability samples collector
matthewnolf
reviewed
Nov 29, 2024
internal/component/database_observability/mysql/collector/query_sample.go
Outdated
Show resolved
Hide resolved
matthewnolf
approved these changes
Dec 2, 2024
internal/component/database_observability/mysql/collector/query_sample_test.go
Outdated
Show resolved
Hide resolved
| require.NoError(t, err) | ||
| }) | ||
|
|
||
| t.Run("Scan() fail", func(t *testing.T) { |
There was a problem hiding this comment.
Can we be more descriptive to the failure mode here, rather than the function call itself which fails
cristiangreco
force-pushed
the
cristian/dbo11y-query-sample-fix
branch
from
ca53086 to
b3a313e
Compare
matthewnolf
approved these changes
Dec 2, 2024
- Skip queries with schema `mysql`, `performance_schema` and `information_schema`, so we're on par with data from mysqld_exporter - Skip truncated queries early before parsing - Do not fail the entire processing loop if a query fails to parse - Log query type - Correctly extract tables from subqueries
…y_sample_test.go Co-authored-by: MattNolf <[email protected]>
cristiangreco
force-pushed
the
cristian/dbo11y-query-sample-fix
branch
from
b3a313e to
37ca4e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
mysql,performance_schemaandinformation_schema, so we're on par with data from mysqld_exporterWhich issue(s) this PR fixes
n.a.
Notes to the Reviewer
PR Checklist