add --formula flag to reinstall command #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents reinstalling the unrelated alloy cask
|
|
clayton-cornell
added
type/docs
clayton-cornell
approved these changes
Nov 26, 2024
|
@maxlemieux It looks like you need to sign the CLA for this project since it's your first contrib in this repo/.project. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
this prevents reinstalling the unrelated alloy cask (cherry picked from commit cfad180)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
this prevents reinstalling the unrelated alloy cask (cherry picked from commit cfad180)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
this prevents reinstalling the unrelated alloy cask (cherry picked from commit cfad180)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
this prevents reinstalling the unrelated alloy cask (cherry picked from commit cfad180)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
this prevents reinstalling the unrelated alloy cask (cherry picked from commit cfad180)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
this prevents reinstalling the unrelated alloy cask (cherry picked from commit cfad180)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fix
brew reinstallcommandWhich issue(s) this PR fixes
The currently documented
brew reinstall alloycommand will reinstall a different "alloy" product via cask, not Grafana Alloy formula.This change prevents reinstalling the unrelated alloy cask instead of Alloy.
Likewise, the settings which are updated in
brew edit alloywill not take effect on areinstallunless the--formulaflag is used.Notes to the Reviewer
I don't think this requires a changelog entry but please let me know if I've missed anything.
PR Checklist