-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up some of the linting warnings and errors #2155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
the
type/docs
Docs Squad label across all Grafana Labs repos
label
Nov 26, 2024
The linting cleanup isn't complete, but this PR is big enough as it is. Time for a review/merge. |
BeverlyJaneJ
approved these changes
Nov 27, 2024
clayton-cornell
commented
Nov 27, 2024
Co-authored-by: Beverly Buchanan <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-2155-to-release/v1.5 origin/release/v1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c27c8ac8eb0edb46a7101f323ef9e65c33b998c6
# Push it to GitHub
git push --set-upstream origin backport-2155-to-release/v1.5
git switch main
# Remove the local backport branch
git branch -D backport-2155-to-release/v1.5 Then, create a pull request where the |
clayton-cornell
added a commit
that referenced
this pull request
Nov 27, 2024
* Clean up some of the linting warnings and errors * Additional linting warning and error cleanup * More work on removing linting errors * More linting cleanup * Even more linting warning cleanup * Fix links to components * Fix link syntax in topic * Correct reference to AWS X-Ray * Add missing link in collect topic * Fix up some redirected links and minor syntax fixes * Fix typo in file name * Apply suggestions from code review Co-authored-by: Beverly Buchanan <[email protected]> --------- Co-authored-by: Beverly Buchanan <[email protected]> (cherry picked from commit c27c8ac)
4 tasks
clayton-cornell
added a commit
that referenced
this pull request
Nov 27, 2024
* Clean up some of the linting warnings and errors * Additional linting warning and error cleanup * More work on removing linting errors * More linting cleanup * Even more linting warning cleanup * Fix links to components * Fix link syntax in topic * Correct reference to AWS X-Ray * Add missing link in collect topic * Fix up some redirected links and minor syntax fixes * Fix typo in file name * Apply suggestions from code review Co-authored-by: Beverly Buchanan <[email protected]> --------- Co-authored-by: Beverly Buchanan <[email protected]> (cherry picked from commit c27c8ac)
clayton-cornell
added a commit
that referenced
this pull request
Nov 28, 2024
…2179) * Clean up some of the linting warnings and errors * Additional linting warning and error cleanup * More work on removing linting errors * More linting cleanup * Even more linting warning cleanup * Fix links to components * Fix link syntax in topic * Correct reference to AWS X-Ray * Add missing link in collect topic * Fix up some redirected links and minor syntax fixes * Fix typo in file name * Apply suggestions from code review Co-authored-by: Beverly Buchanan <[email protected]> --------- Co-authored-by: Beverly Buchanan <[email protected]> (cherry picked from commit c27c8ac)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport release/v1.5
backport-failed
frozen-due-to-age
type/docs
Docs Squad label across all Grafana Labs repos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Clean up linting warnings and errors in the Alloy docs. Some issues (especially passive voice) remain in the various topics. It will take multiple passes to get the warnings/errors down to a manageable level.
Changes here include:
*
for consistencylet's
andwe
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist