True up the documentation with the code. #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehaansa
approved these changes
Nov 14, 2024
clayton-cornell
approved these changes
Nov 14, 2024
clayton-cornell
added
the
type/docs
|
This was documented as |
|
I think its always been false. There are some shenanigans with init in the node exporter package but that hasnt been updated since last year. |
|
OK, so I will add backport labels here and get this small change pulled into the previous versions of the docs - doesn't hurt to keep things in sync :-) |
|
I think this has always been default to false, even node_exporter the underlying library sets it to false. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 8b5c04f)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 8b5c04f)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 8b5c04f)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 8b5c04f)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 8b5c04f)
This was referenced Nov 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 8b5c04f)
This was referenced Nov 14, 2024
vaxvms
pushed a commit
to vaxvms/alloy
that referenced
this pull request
Nov 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation only change, verified these flags are both false by default.