-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pod labels to include all labels #2071
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jimmy Bourque <[email protected]>
@petewall Is there anything specific I need to get this PR to continue its workflow? It's been stuck for a couple of days now at the continuous-integration step and when I click Details it just says to contact the repo admin. :( If there's something I'm missing from my PR, I'm more than happy to address that. Thanks!!! |
I approved and kicked off the build. |
Thanks @mattdurham!!! It looks like I needed to run a script to update the tests. I'm guessing that's why it failed at the previous step, but I think it should be good now. |
@petewall Any chance you or someone else can take a look at this PR please? |
This PR has not had any activity in the past 30 days, so the |
@petewall @mattdurham Is there anything else I need to do for this to get reviewed/accepted? |
PR Description
Updates the _pod.yaml file to include the same labels used in the DaemonSet/StatefulSet/Deployment to help improve traceability throughout the application. The new labels include the selectorLabels which it was previously using so this should only be adding additional labels and not removing any.
Which issue(s) this PR fixes
#2070
#issue_id
Notes to the Reviewer
PR Checklist