Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configuration Syntax doc URL 404ing #163

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

terraboops
Copy link
Contributor

Fixes link in docs.

s/config/configuration/

  • Documentation added

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As soon as the CLA is signed I'll merge :)

@rfratto rfratto enabled auto-merge (squash) April 9, 2024 22:48
@terraboops
Copy link
Contributor Author

@rfratto I work at Grafana- but I can sign a CLA if we need ;p

@terraboops
Copy link
Contributor Author

@rfratto I found another issue - hold off on merging plz :)

@rfratto
Copy link
Member

rfratto commented Apr 9, 2024

@rfratto I work at Grafana- but I can sign a CLA if we need ;p

Yeah I'm not sure why it's flagging you as needing to sign one (org members are supposed to be excluded IIUC), but it's a marked as a required check so we aren't able to merge until it's signed 😅 Sorry!

@rfratto rfratto disabled auto-merge April 9, 2024 22:51
s/getting_started/get-started/
@terraboops
Copy link
Contributor Author

Okay! @rfratto -- I've checked all the links and fixed the two pointing to outdated URLs.

CLA should be signed now. Merge when ready! :shipit:

@rfratto
Copy link
Member

rfratto commented Apr 9, 2024

Nice, thanks again!

@rfratto rfratto enabled auto-merge (squash) April 9, 2024 22:54
@rfratto rfratto merged commit 23e5170 into grafana:main Apr 9, 2024
10 checks passed
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants