Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document backwards compatibility #140

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 8, 2024

Document backwards compatability based on the grafana/agent backwards compatability RFC. Some changes have been made:

  • Mention of major release burnout has been removed. We will continue to try to limit major releases to once per calendar year, but I'm not sure it's worth documenting.

  • LTS support for previous major releases has been removed. The RFC was less formal, and it's not clear how we'll continue to support v1 as v2 gets released. That sounds more like a problem for when we release v2 :)

  • "The scope of backwards compatibility" has been removed from the backwards compatability list, as it is needlessly verbose and we may have forgotten an obvious exception.

  • The exceptions "undocumented behavior," "tagged as exempt," "other telemetry data," and "non-versioned network APIs" have been integrated elsewhere in the doc to keep the list of exceptions shorter.

  • "Bugs" and "specification errors" have been added to the exception list, as incorrect behavior that is relied on may require a breaking change, and contradictory specification in the documentation may need to be resolved by breaking compatibility.

Despite the changes above, the intent is still the same: we strive wherever possible to maintain compatability for users between minor and patch releases.

Document backwards compatability based on the grafana/agent backwards
compatability [RFC]. Some changes have been made:

* Major release burnout and LTS suppor for previous major releases is
  not mentioned.

* "The scope of backwards compatability" has been removed from the
  backwards compatability list, as it is needlessly verbose and we may
  have forgotten an obvious exception.

* The exceptions "undocumented behavior," "tagged as exempt," "other
  telemetry data," and "non-versioned network APIs" have been integrated
  elsewhere in the doc to keep the list of exceptions shorter.

Despite the changes above, the intent is still the same: we strive
wherever possible to maintain compatability for users between minor and
patch releases.

[RFC]: https://github.com/grafana/agent/blob/main/docs/rfcs/0008-backwards-compatibility.md
Copy link
Contributor

@ptodev ptodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with making this brief and expanding it as time goes on. It'd be much better than making it very detailed, only to change it later and risk surprising users.

docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few cases of passive voice, but it's OK.

Can we change the filename to backward-compatibility.md (US English spelling style).

Location in the TOC... I'd like to see this included in the Introduction section vs out in the doc root (where it is now). This will group it with the release cadence and supported platforms topics

docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
docs/sources/backwards-compatability.md Outdated Show resolved Hide resolved
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Apr 8, 2024
@rfratto rfratto merged commit 38fd764 into main Apr 8, 2024
9 checks passed
@rfratto rfratto deleted the backwards-compatability branch April 8, 2024 15:03
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
Document backwards compatability based on the grafana/agent backwards
compatability [RFC]. Some changes have been made:

* Major release burnout and LTS suppor for previous major releases is
  not mentioned.

* "The scope of backwards compatability" has been removed from the
  backwards compatability list, as it is needlessly verbose and we may
  have forgotten an obvious exception.

* The exceptions "undocumented behavior," "tagged as exempt," "other
  telemetry data," and "non-versioned network APIs" have been integrated
  elsewhere in the doc to keep the list of exceptions shorter.

Despite the changes above, the intent is still the same: we strive
wherever possible to maintain compatability for users between minor and
patch releases.

[RFC]: https://github.com/grafana/agent/blob/main/docs/rfcs/0008-backwards-compatibility.md

Co-authored-by: Paulin Todev <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 38fd764)
rfratto added a commit that referenced this pull request Apr 8, 2024
Document backwards compatability based on the grafana/agent backwards
compatability [RFC]. Some changes have been made:

* Major release burnout and LTS suppor for previous major releases is
  not mentioned.

* "The scope of backwards compatability" has been removed from the
  backwards compatability list, as it is needlessly verbose and we may
  have forgotten an obvious exception.

* The exceptions "undocumented behavior," "tagged as exempt," "other
  telemetry data," and "non-versioned network APIs" have been integrated
  elsewhere in the doc to keep the list of exceptions shorter.

Despite the changes above, the intent is still the same: we strive
wherever possible to maintain compatability for users between minor and
patch releases.

[RFC]: https://github.com/grafana/agent/blob/main/docs/rfcs/0008-backwards-compatibility.md

(cherry picked from commit 38fd764)

Co-authored-by: Robert Fratto <[email protected]>
Co-authored-by: Paulin Todev <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release/v1.0 backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants