Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: fix Windows container #135

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Docker: fix Windows container #135

merged 1 commit into from
Apr 5, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 5, 2024

  • Fix CI job to check Windows container builds properly
  • Ensures Windows containers end in -nanoserver-1809 as is our new convention
  • Add make alloy-image-windows target to Makefile

@rfratto rfratto requested a review from clayton-cornell as a code owner April 5, 2024 18:37
* Fix CI job to check Windows container builds properly
* Ensures Windows containers end in `-nanoserver-1809` as is our new
  convention
* Add `make alloy-image-windows` target to Makefile
* Apply previous fixes to dev container
@rfratto rfratto force-pushed the fix-check-windows-container branch from ae52fdc to c90557a Compare April 5, 2024 18:41
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Apr 5, 2024
@rfratto rfratto merged commit a524386 into main Apr 5, 2024
10 checks passed
@rfratto rfratto deleted the fix-check-windows-container branch April 5, 2024 18:47
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants