Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm/charts/alloy: update default listen port to 12345 #127

Merged
merged 1 commit into from
Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion operations/helm/charts/alloy/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ internal API changes are not present.

- Introduce a Grafana Alloy Helm chart. The Grafana Alloy Helm chart is
backwards compatibile with the values.yaml from the `grafana-agent` Helm
chart. (@rfratto)
chart. Review the Helm chart README for a description on how to migrate.
(@rfratto)
14 changes: 13 additions & 1 deletion operations/helm/charts/alloy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ useful if just using the default DaemonSet isn't sufficient.
| alloy.extraEnv | list | `[]` | Extra environment variables to pass to the Alloy container. |
| alloy.extraPorts | list | `[]` | Extra ports to expose on the Alloy container. |
| alloy.listenAddr | string | `"0.0.0.0"` | Address to listen for traffic on. 0.0.0.0 exposes the UI to other containers. |
| alloy.listenPort | int | `80` | Port to listen for traffic on. |
| alloy.listenPort | int | `12345` | Port to listen for traffic on. |
| alloy.listenScheme | string | `"HTTP"` | Scheme is needed for readiness probes. If enabling tls in your configs, set to "HTTPS" |
| alloy.mounts.dockercontainers | bool | `false` | Mount /var/lib/docker/containers from the host into the container for log collection. |
| alloy.mounts.extra | list | `[]` | Extra volume mounts to add into the Grafana Alloy container. Does not affect the watch container. |
Expand Down Expand Up @@ -131,6 +131,18 @@ useful if just using the default DaemonSet isn't sufficient.
| serviceMonitor.relabelings | list | `[]` | RelabelConfigs to apply to samples before scraping ref: https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#relabelconfig |
| serviceMonitor.tlsConfig | object | `{}` | Customize tls parameters for the service monitor |

#### Migrate from `grafana/grafana-agent` chart to `grafana/alloy`

The `values.yaml` file for the `grafana/grafana-agent` chart is compatible with
the chart for `grafana/alloy`, with two exceptions:

* The `agent` field in `values.yaml` is deprecated in favor of `alloy`. Support
for the `agent` field will be removed in a future release.

* The default value for `alloy.listenPort` is `12345` to align with the default
listen port in other installations. To retain the previous default, set
`alloy.listenPort` to `80` when installing.

### alloy.extraArgs

`alloy.extraArgs` allows for passing extra arguments to the Grafana Alloy
Expand Down
12 changes: 12 additions & 0 deletions operations/helm/charts/alloy/README.md.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,18 @@ useful if just using the default DaemonSet isn't sufficient.

{{ template "chart.valuesSection" . }}

#### Migrate from `grafana/grafana-agent` chart to `grafana/alloy`

The `values.yaml` file for the `grafana/grafana-agent` chart is compatible with
the chart for `grafana/alloy`, with two exceptions:

* The `agent` field in `values.yaml` is deprecated in favor of `alloy`. Support
for the `agent` field will be removed in a future release.

* The default value for `alloy.listenPort` is `12345` to align with the default
listen port in other installations. To retain the previous default, set
`alloy.listenPort` to `80` when installing.

### alloy.extraArgs

`alloy.extraArgs` allows for passing extra arguments to the Grafana Alloy
Expand Down
2 changes: 1 addition & 1 deletion operations/helm/charts/alloy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ alloy:
listenAddr: 0.0.0.0

# -- Port to listen for traffic on.
listenPort: 80
listenPort: 12345

# -- Scheme is needed for readiness probes. If enabling tls in your configs, set to "HTTPS"
listenScheme: HTTP
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
- run
- /etc/alloy/config.alloy
- --storage.path=/tmp/alloy
- --server.http.listen-addr=0.0.0.0:80
- --server.http.listen-addr=0.0.0.0:12345
- --server.http.ui-path-prefix=/
env:
- name: ALLOY_DEPLOY_MODE
Expand All @@ -43,12 +43,12 @@ spec:
fieldRef:
fieldPath: spec.nodeName
ports:
- containerPort: 80
- containerPort: 12345
name: http-metrics
readinessProbe:
httpGet:
path: /-/ready
port: 80
port: 12345
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 1
Expand All @@ -59,7 +59,7 @@ spec:
image: ghcr.io/jimmidyson/configmap-reload:v0.12.0
args:
- --volume-dir=/etc/alloy
- --webhook-url=http://localhost:80/-/reload
- --webhook-url=http://localhost:12345/-/reload
volumeMounts:
- name: config
mountPath: /etc/alloy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ spec:
internalTrafficPolicy: Cluster
ports:
- name: http-metrics
port: 80
targetPort: 80
port: 12345
targetPort: 12345
protocol: "TCP"
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ spec:
# This service should only be used for clustering, and not metric
# collection.
- name: http
port: 80
targetPort: 80
port: 12345
targetPort: 12345
protocol: "TCP"
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ spec:
- run
- /etc/alloy/config.alloy
- --storage.path=/tmp/alloy
- --server.http.listen-addr=0.0.0.0:80
- --server.http.listen-addr=0.0.0.0:12345
- --server.http.ui-path-prefix=/
- --cluster.enabled=true
- --cluster.join-addresses=alloy-cluster
Expand All @@ -48,12 +48,12 @@ spec:
fieldRef:
fieldPath: spec.nodeName
ports:
- containerPort: 80
- containerPort: 12345
name: http-metrics
readinessProbe:
httpGet:
path: /-/ready
port: 80
port: 12345
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 1
Expand All @@ -64,7 +64,7 @@ spec:
image: ghcr.io/jimmidyson/configmap-reload:v0.12.0
args:
- --volume-dir=/etc/alloy
- --webhook-url=http://localhost:80/-/reload
- --webhook-url=http://localhost:12345/-/reload
volumeMounts:
- name: config
mountPath: /etc/alloy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ spec:
internalTrafficPolicy: Cluster
ports:
- name: http-metrics
port: 80
targetPort: 80
port: 12345
targetPort: 12345
protocol: "TCP"
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
- run
- /etc/alloy/config.alloy
- --storage.path=/tmp/alloy
- --server.http.listen-addr=0.0.0.0:80
- --server.http.listen-addr=0.0.0.0:12345
- --server.http.ui-path-prefix=/
env:
- name: ALLOY_DEPLOY_MODE
Expand All @@ -43,12 +43,12 @@ spec:
fieldRef:
fieldPath: spec.nodeName
ports:
- containerPort: 80
- containerPort: 12345
name: http-metrics
readinessProbe:
httpGet:
path: /-/ready
port: 80
port: 12345
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 1
Expand All @@ -62,7 +62,7 @@ spec:
image: ghcr.io/jimmidyson/configmap-reload:v0.12.0
args:
- --volume-dir=/etc/alloy
- --webhook-url=http://localhost:80/-/reload
- --webhook-url=http://localhost:12345/-/reload
volumeMounts:
- name: config
mountPath: /etc/alloy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ spec:
internalTrafficPolicy: Cluster
ports:
- name: http-metrics
port: 80
targetPort: 80
port: 12345
targetPort: 12345
protocol: "TCP"
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
- run
- /etc/alloy/config.alloy
- --storage.path=/tmp/alloy
- --server.http.listen-addr=0.0.0.0:80
- --server.http.listen-addr=0.0.0.0:12345
- --server.http.ui-path-prefix=/
env:
- name: ALLOY_DEPLOY_MODE
Expand All @@ -43,12 +43,12 @@ spec:
fieldRef:
fieldPath: spec.nodeName
ports:
- containerPort: 80
- containerPort: 12345
name: http-metrics
readinessProbe:
httpGet:
path: /-/ready
port: 80
port: 12345
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 1
Expand All @@ -59,7 +59,7 @@ spec:
image: ghcr.io/jimmidyson/configmap-reload:v0.12.0
args:
- --volume-dir=/etc/alloy
- --webhook-url=http://localhost:80/-/reload
- --webhook-url=http://localhost:12345/-/reload
volumeMounts:
- name: config
mountPath: /etc/alloy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ spec:
internalTrafficPolicy: Cluster
ports:
- name: http-metrics
port: 80
targetPort: 80
port: 12345
targetPort: 12345
protocol: "TCP"
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
- run
- /etc/alloy/config.alloy
- --storage.path=/tmp/alloy
- --server.http.listen-addr=0.0.0.0:80
- --server.http.listen-addr=0.0.0.0:12345
- --server.http.ui-path-prefix=/
env:
- name: ALLOY_DEPLOY_MODE
Expand All @@ -43,12 +43,12 @@ spec:
fieldRef:
fieldPath: spec.nodeName
ports:
- containerPort: 80
- containerPort: 12345
name: http-metrics
readinessProbe:
httpGet:
path: /-/ready
port: 80
port: 12345
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 1
Expand All @@ -59,7 +59,7 @@ spec:
image: ghcr.io/jimmidyson/configmap-reload:v0.12.0
args:
- --volume-dir=/etc/alloy
- --webhook-url=http://localhost:80/-/reload
- --webhook-url=http://localhost:12345/-/reload
volumeMounts:
- name: config
mountPath: /etc/alloy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ spec:
internalTrafficPolicy: Cluster
ports:
- name: http-metrics
port: 80
targetPort: 80
port: 12345
targetPort: 12345
protocol: "TCP"
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
- run
- /etc/alloy/config.alloy
- --storage.path=/tmp/alloy
- --server.http.listen-addr=0.0.0.0:80
- --server.http.listen-addr=0.0.0.0:12345
- --server.http.ui-path-prefix=/
env:
- name: ALLOY_DEPLOY_MODE
Expand All @@ -43,12 +43,12 @@ spec:
fieldRef:
fieldPath: spec.nodeName
ports:
- containerPort: 80
- containerPort: 12345
name: http-metrics
readinessProbe:
httpGet:
path: /-/ready
port: 80
port: 12345
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 1
Expand All @@ -62,7 +62,7 @@ spec:
image: ghcr.io/jimmidyson/configmap-reload:v0.12.0
args:
- --volume-dir=/etc/alloy
- --webhook-url=http://localhost:80/-/reload
- --webhook-url=http://localhost:12345/-/reload
volumeMounts:
- name: config
mountPath: /etc/alloy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ spec:
internalTrafficPolicy: Cluster
ports:
- name: http-metrics
port: 80
targetPort: 80
port: 12345
targetPort: 12345
protocol: "TCP"
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
- run
- /etc/alloy/config.alloy
- --storage.path=/tmp/alloy
- --server.http.listen-addr=0.0.0.0:80
- --server.http.listen-addr=0.0.0.0:12345
- --server.http.ui-path-prefix=/
env:
- name: ALLOY_DEPLOY_MODE
Expand All @@ -44,12 +44,12 @@ spec:
fieldRef:
fieldPath: spec.nodeName
ports:
- containerPort: 80
- containerPort: 12345
name: http-metrics
readinessProbe:
httpGet:
path: /-/ready
port: 80
port: 12345
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 1
Expand All @@ -60,7 +60,7 @@ spec:
image: ghcr.io/jimmidyson/configmap-reload:v0.12.0
args:
- --volume-dir=/etc/alloy
- --webhook-url=http://localhost:80/-/reload
- --webhook-url=http://localhost:12345/-/reload
volumeMounts:
- name: config
mountPath: /etc/alloy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ spec:
internalTrafficPolicy: Cluster
ports:
- name: http-metrics
port: 80
targetPort: 80
port: 12345
targetPort: 12345
protocol: "TCP"
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ spec:
- run
- /etc/alloy/config.alloy
- --storage.path=/tmp/alloy
- --server.http.listen-addr=0.0.0.0:80
- --server.http.listen-addr=0.0.0.0:12345
- --server.http.ui-path-prefix=/
env:
- name: ALLOY_DEPLOY_MODE
Expand All @@ -45,12 +45,12 @@ spec:
fieldRef:
fieldPath: spec.nodeName
ports:
- containerPort: 80
- containerPort: 12345
name: http-metrics
readinessProbe:
httpGet:
path: /-/ready
port: 80
port: 12345
scheme: HTTP
initialDelaySeconds: 10
timeoutSeconds: 1
Expand All @@ -64,7 +64,7 @@ spec:
image: ghcr.io/jimmidyson/configmap-reload:v0.12.0
args:
- --volume-dir=/etc/alloy
- --webhook-url=http://localhost:80/-/reload
- --webhook-url=http://localhost:12345/-/reload
volumeMounts:
- name: config
mountPath: /etc/alloy
Expand Down
Loading
Loading