fix: fully prevent panic in remotecfg ui (#2164)

* Fully prevent panic in remotecfg ui * Address PR feedback
grafana · Dec 3, 2024 · c2828ec · c2828ec
1 parent ed85f2e
commit c2828ec
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/internal/web/api/api.go b/internal/web/api/api.go
@@ -66,7 +66,12 @@ func listComponentsHandlerRemoteCfg(host service.Host) http.HandlerFunc {
 			return
 		}
 
-		listComponentsHandlerInternal(svc.Data().(remotecfg.Data).Host, w, r)
+		data := svc.Data().(remotecfg.Data)
+		if data.Host == nil {
+			http.Error(w, "remote config service startup in progress", http.StatusInternalServerError)
+			return
+		}
+		listComponentsHandlerInternal(data.Host, w, r)
 	}
 }
 
@@ -108,7 +113,13 @@ func getComponentHandlerRemoteCfg(host service.Host) http.HandlerFunc {
 			return
 		}
 
-		getComponentHandlerInternal(svc.Data().(remotecfg.Data).Host, w, r)
+		data := svc.Data().(remotecfg.Data)
+		if data.Host == nil {
+			http.Error(w, "remote config service startup in progress", http.StatusInternalServerError)
+			return
+		}
+
+		getComponentHandlerInternal(data.Host, w, r)
 	}
 }