Remove set bind permissions #7078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptodev
force-pushed
the
ptodev/remove-libcap
branch
from
98ace31 to
4acfc13
Compare
wildum
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting this fix from Alloy to Agent. It is requested by users whose Agents fail to start due to a "operation not permitted" error.
The reason why Agent requests
cap_net_bind_serviceis that it listens on port 80 by default. Thus, if someone configures Alloy with the non-root user with ID 473, they'd need that capability. However, this is As the Alloy issue states, Docker has been enabling that capability by default for a long time now. So even for non-root users we wouldn't really need to set it.Since only non-root users would encounter this, and non-root support is experimental, it's ok to remove the capability anyway.