Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a tenant example to prometheus.remote_write.md #5737

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

thecoldwine
Copy link
Contributor

PR Description

This PR adds an example for pushing the metrics to a multi-tenant Mimir instance with non-default tenant.

It could be useful for people who have less experience with multi-tenant Mimir, but would like to have a clear example how to use recommended way for ingestion there.

Notes to the Reviewer

There are no functional changes, just one particular example in the prometheus.remote_write config.

PR Checklist

  • Documentation added

This commit adds an example for pushing the metrics to a multi-tenant Mimir instance with non-default tenant.

It could be useful for people who have less experience with multi-tenant Mimir, but would like to have a clear example how to use recommended way for ingestion there.
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@clayton-cornell
Copy link
Contributor

@grafana/grafana-agent-maintainers Can one of you take a quick look over the example to double check the technical accuracy

Copy link
Contributor

@spartan0x117 spartan0x117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a technical perspective looks good, just one comment around having a more generic url and comment 😃

Copy link
Contributor

@spartan0x117 spartan0x117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit but LGTM, thank you!

@clayton-cornell
Copy link
Contributor

@thecoldwine Thanks for your input here. Getting this PR merged into Main :-)

@clayton-cornell clayton-cornell merged commit 1caf600 into grafana:main Nov 9, 2023
8 checks passed
grafanabot pushed a commit that referenced this pull request Nov 9, 2023
* Add a tenant example to prometheus.remote_write.md

This commit adds an example for pushing the metrics to a multi-tenant Mimir instance with non-default tenant.

It could be useful for people who have less experience with multi-tenant Mimir, but would like to have a clear example how to use recommended way for ingestion there.

* Update docs/sources/flow/reference/components/prometheus.remote_write.md

Add a missing article.

Co-authored-by: Clayton Cornell <[email protected]>

* formatting + more generic Mimir url in the snippet

* A minor nit

Co-authored-by: Mischa Thompson <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Mischa Thompson <[email protected]>
(cherry picked from commit 1caf600)
grafanabot pushed a commit that referenced this pull request Nov 9, 2023
* Add a tenant example to prometheus.remote_write.md

This commit adds an example for pushing the metrics to a multi-tenant Mimir instance with non-default tenant.

It could be useful for people who have less experience with multi-tenant Mimir, but would like to have a clear example how to use recommended way for ingestion there.

* Update docs/sources/flow/reference/components/prometheus.remote_write.md

Add a missing article.

Co-authored-by: Clayton Cornell <[email protected]>

* formatting + more generic Mimir url in the snippet

* A minor nit

Co-authored-by: Mischa Thompson <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Mischa Thompson <[email protected]>
(cherry picked from commit 1caf600)
grafanabot pushed a commit that referenced this pull request Nov 9, 2023
* Add a tenant example to prometheus.remote_write.md

This commit adds an example for pushing the metrics to a multi-tenant Mimir instance with non-default tenant.

It could be useful for people who have less experience with multi-tenant Mimir, but would like to have a clear example how to use recommended way for ingestion there.

* Update docs/sources/flow/reference/components/prometheus.remote_write.md

Add a missing article.

Co-authored-by: Clayton Cornell <[email protected]>

* formatting + more generic Mimir url in the snippet

* A minor nit

Co-authored-by: Mischa Thompson <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Mischa Thompson <[email protected]>
(cherry picked from commit 1caf600)
clayton-cornell pushed a commit that referenced this pull request Nov 9, 2023
* Add a tenant example to prometheus.remote_write.md

This commit adds an example for pushing the metrics to a multi-tenant Mimir instance with non-default tenant.

It could be useful for people who have less experience with multi-tenant Mimir, but would like to have a clear example how to use recommended way for ingestion there.

* Update docs/sources/flow/reference/components/prometheus.remote_write.md

Add a missing article.

Co-authored-by: Clayton Cornell <[email protected]>

* formatting + more generic Mimir url in the snippet

* A minor nit

Co-authored-by: Mischa Thompson <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Mischa Thompson <[email protected]>
(cherry picked from commit 1caf600)

Co-authored-by: Mikhail Aksenov <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Nov 9, 2023
* Add a tenant example to prometheus.remote_write.md

This commit adds an example for pushing the metrics to a multi-tenant Mimir instance with non-default tenant.

It could be useful for people who have less experience with multi-tenant Mimir, but would like to have a clear example how to use recommended way for ingestion there.

* Update docs/sources/flow/reference/components/prometheus.remote_write.md

Add a missing article.

Co-authored-by: Clayton Cornell <[email protected]>

* formatting + more generic Mimir url in the snippet

* A minor nit

Co-authored-by: Mischa Thompson <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Mischa Thompson <[email protected]>
(cherry picked from commit 1caf600)

Co-authored-by: Mikhail Aksenov <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Nov 9, 2023
* Add a tenant example to prometheus.remote_write.md

This commit adds an example for pushing the metrics to a multi-tenant Mimir instance with non-default tenant.

It could be useful for people who have less experience with multi-tenant Mimir, but would like to have a clear example how to use recommended way for ingestion there.

* Update docs/sources/flow/reference/components/prometheus.remote_write.md

Add a missing article.

Co-authored-by: Clayton Cornell <[email protected]>

* formatting + more generic Mimir url in the snippet

* A minor nit

Co-authored-by: Mischa Thompson <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Mischa Thompson <[email protected]>
(cherry picked from commit 1caf600)

Co-authored-by: Mikhail Aksenov <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.35 backport release-v0.36 backport release-v0.37 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants