Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Static pods missing in the discovery.kubelet output #5644 #5735

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

masonmei
Copy link
Contributor

@masonmei masonmei commented Nov 8, 2023

PR Description

Update the buildPodTargetGroup function in discovery.kubelet to hand containers that has no pod defined. This is useful for logs collecting with files in local.

image

Which issue(s) this PR fixes

Fixes #5644

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @masonmei !

@tpaschalis tpaschalis enabled auto-merge (squash) November 10, 2023 09:56
@tpaschalis tpaschalis merged commit 461a4b2 into grafana:main Nov 16, 2023
8 checks passed
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static pods missing in the discovery.kubelet output
2 participants