loki/wal: fix panic for duplicate registered metrics #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
thepalbi
approved these changes
Nov 3, 2023
|
cc @thepalbi I'm merging this, you might have to rebase your other PR, sorry for the trouble! |
tpaschalis
added a commit
to tpaschalis/agent
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Paschalis Tsilias <[email protected]> (cherry picked from commit 7817c22)
tpaschalis
added a commit
that referenced
this pull request
Nov 6, 2023
* loki/wal: fix panic for duplicate registered metrics (#5705) Signed-off-by: Paschalis Tsilias <[email protected]> (cherry picked from commit 7817c22) * otelcol.exporter.prometheus add_metrics_suffixes option (#5568) * otelcol.exporter.prometheus add add_metrics_suffixes option * otelcol.exporter.prometheus add add_metrics_suffixes option. Add tests * otelcol.exporter.prometheus add add_metrics_suffixes option. Update docs * otelcol.exporter.prometheus add add_metrics_suffixes option. Added changelog, fixed readme * otelcol.exporter.prometheus add add_metric_suffixes option. Fix option name * otelcol.exporter.prometheus add add_metric_suffixes option. Add more tests * otelcol.exporter.prometheus add add_metric_suffixes option. Added convertArgumentsToConvertOptions * otelcol.exporter.prometheus add add_metric_suffixes option. Fix changelog message (cherry picked from commit 5a7c16a) --------- Co-authored-by: Irina <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The original issue in #5414 is easily reproducible by changing the configuration of a
loki.writecomponent and hitting the reload endpoint, as the NewWatcherMetrics will attempt to re-register the same set of metrics.Which issue(s) this PR fixes
Fixes #5414
Notes to the Reviewer
Another possible fix would be to create these metrics at the top-level, when creating a New component and propagate a pointer to the metrics struct down to here. Both solutions could work, but for now, this is what we've mainly been doing in loki.* components when forklifting Promtail code, so an argument can be made to leave this as-is for now to not trip off people when trying to bring new Promtail code in.
PR Checklist