Clearer converter diagnostics #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here possible for validation. Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
update migration doc output to match current behaviour Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
erikbaranowski
requested review from
clayton-cornell and
a team
as code owners
erikbaranowski
commented
Oct 17, 2023
| @@ -17,19 +17,44 @@ func UnsupportedNotDeepEqualsMessage(a any, b any, name string, message string) | |||
| var diags diag.Diagnostics | |||
| if !reflect.DeepEqual(a, b) { | |||
| if message != "" { | |||
| diags.Add(diag.SeverityLevelError, fmt.Sprintf("unsupported %s config was provided: %s", name, message)) | |||
| diags.Add(diag.SeverityLevelError, fmt.Sprintf("The converter does not support converting the provided %s config: %s", name, message)) | |||
There was a problem hiding this comment.
@clayton-cornell please check out the wording in these diagnostic messages throughout to let me know what you think. There was some confusion between if something is a Flow error vs a Converter error that I'm trying to alleviate with these updates.
mattdurham
reviewed
Oct 17, 2023
mattdurham
reviewed
Oct 17, 2023
mattdurham
approved these changes
Oct 17, 2023
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
thampiotr
approved these changes
Oct 18, 2023
clayton-cornell
added
the
type/docs
tpaschalis
pushed a commit
to tpaschalis/agent
that referenced
this pull request
Oct 25, 2023
* Update a bunch of converter messages and use standardized functions where possible for validation. * default promtail log level from static converter so warnings don't show * update migration doc output to match current behaviour * refactor validation helper functions Signed-off-by: erikbaranowski <[email protected]> --------- Signed-off-by: erikbaranowski <[email protected]> (cherry picked from commit 06c6792)
tpaschalis
added a commit
that referenced
this pull request
Oct 26, 2023
* go get google.golang.org/[email protected] (#5511) (cherry picked from commit 1d11d37) * Upgrade Agent to Collector 0.87 (#5529) * Upgrade Agent to Collector 0.87 * Parametrize the OTel version in docs. * Document another batch processor metric * Don't accept routing keys for metrics. * Add tests for otelcol.receiver.kafka --------- Co-authored-by: Mischa Thompson <[email protected]> (cherry picked from commit b307c02) * prometheus.remote_write: fix missing series ref mapping for native histogram (#5517) Signed-off-by: György Krajcsovits <[email protected]> Co-authored-by: Paschalis Tsilias <[email protected]> (cherry picked from commit 5794224) * pkg/metrics/wal: drop out-of-order exemplars (#5580) Signed-off-by: Paschalis Tsilias <[email protected]> (cherry picked from commit cd9d185) * remote.vault: respect value of `namespace` argument (#5582) Unfortunately, this setting can't be easily tested because Vault namespaces are an enterprise-only feature. Co-authored-by: Paschalis Tsilias <[email protected]> (cherry picked from commit c0a52bc) * reorganize prometheus converter code and limit surface area of dependencies between converters (#5406) Signed-off-by: erikbaranowski <[email protected]> (cherry picked from commit 5d39145) * Clearer converter diagnostics (#5505) * Update a bunch of converter messages and use standardized functions where possible for validation. * default promtail log level from static converter so warnings don't show * update migration doc output to match current behaviour * refactor validation helper functions Signed-off-by: erikbaranowski <[email protected]> --------- Signed-off-by: erikbaranowski <[email protected]> (cherry picked from commit 06c6792) * wire up the agent integration for the static converter (#5545) * wire up the agent integration for the static converter Signed-off-by: erikbaranowski <[email protected]> --------- Signed-off-by: erikbaranowski <[email protected]> (cherry picked from commit f4e6ac4) * converters: Default with localhost in static targets when none provided (#5546) * promtail: Default with localhost in static targets in converter * Add tests and changelog * prettify * feedback (cherry picked from commit 8850660) --------- Co-authored-by: Mischa Thompson <[email protected]> Co-authored-by: Paulin Todev <[email protected]> Co-authored-by: George Krajcsovits <[email protected]> Co-authored-by: Robert Fratto <[email protected]> Co-authored-by: Erik Baranowski <[email protected]> Co-authored-by: Piotr <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist