Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify which Vault "remote.vault" connects to #5503

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Oct 16, 2023

I'm surprised that "HashiCorp" is not mentioned in the docs for remote.vault. "Vault" is a term which is so overused in the security space, that probably even the component should have been called remote.hashicorp_vault.

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I learned something new today :-)

@clayton-cornell clayton-cornell merged commit 4d07963 into main Oct 16, 2023
@clayton-cornell clayton-cornell deleted the ptodev/clarify-vault branch October 16, 2023 20:47
grafanabot pushed a commit that referenced this pull request Oct 16, 2023
grafanabot pushed a commit that referenced this pull request Oct 16, 2023
grafanabot pushed a commit that referenced this pull request Oct 16, 2023
clayton-cornell pushed a commit that referenced this pull request Oct 16, 2023
(cherry picked from commit 4d07963)

Co-authored-by: Paulin Todev <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Oct 16, 2023
(cherry picked from commit 4d07963)

Co-authored-by: Paulin Todev <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Oct 16, 2023
(cherry picked from commit 4d07963)

Co-authored-by: Paulin Todev <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.35 backport release-v0.36 backport release-v0.37 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants