Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow out of order samples to be written to the WAL (#5487) #5490

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Allow out of order samples to be written to the WAL (#5487) #5490

merged 1 commit into from
Oct 16, 2023

Conversation

tpaschalis
Copy link
Member

Cherry-pick #5487 from main that allows OOO samples to be written to the WAL.

@mattdurham @tpaschalis
Allow out of order samples to be written to the WAL. (grafana#5487)
e335cde 
* Allow out of order samples to be written to the WAL.

* changelog

(cherry picked from commit da2cd08)
@tpaschalis tpaschalis requested a review from a team as a code owner October 16, 2023 14:18
@tpaschalis tpaschalis self-assigned this Oct 16, 2023
@tpaschalis tpaschalis requested a review from mattdurham October 16, 2023 14:18
@tpaschalis tpaschalis removed their assignment Oct 16, 2023
mattdurham
mattdurham approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpaschalis tpaschalis merged commit 7275f65 into grafana:release-v0.37 Oct 16, 2023
6 checks passed
tpaschalis added a commit to tpaschalis/agent that referenced this pull request Oct 17, 2023
@tpaschalis
Revert "Allow out of order samples to be written to the WAL (grafana#…
2158e9b 
…5490)"

This reverts commit 7275f65.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattdurham mattdurham mattdurham approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpaschalis @mattdurham