Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki.process: add decolorise stage support #5416

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

thampiotr
Copy link
Contributor

@thampiotr thampiotr commented Oct 9, 2023

PR Description

Part of #4836
This fell through the cracks for feature parity.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@thampiotr thampiotr force-pushed the thampiotr/add-decolorize-loki-process-stage branch from 281423f to 9f81e4e Compare October 9, 2023 15:32
@thampiotr thampiotr marked this pull request as ready for review October 9, 2023 15:52
@thampiotr thampiotr requested review from a team and clayton-cornell as code owners October 9, 2023 15:52
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thampiotr
Copy link
Contributor Author

I'll hold off with merging to let @clayton-cornell review the docs.

@thampiotr
Copy link
Contributor Author

I'll hold off with merging to let @clayton-cornell review the docs.

I'll merge this now as I need some of the changes to continue more work on loki.process and the docs are heavily inspired by existing promtail docs. But if there are any requests to improve the docs, please let me know and I'll be fixing it.

@thampiotr thampiotr merged commit 0d6ad63 into main Oct 10, 2023
6 checks passed
@thampiotr thampiotr deleted the thampiotr/add-decolorize-loki-process-stage branch October 10, 2023 09:34
@clayton-cornell
Copy link
Contributor

@ptodev Dos are ok here :-)

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Oct 11, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants